#1249 Bug (& patch) in userslib.php

v1.8RC
closed-fixed
nobody
PHP Error (166)
5
2004-03-31
2004-02-06
No

One query is not properly quoted as per the following
patch:

--- lib/userslib.php.orig 2003-12-22
23:18:51.000000000 +1100
+++ lib/userslib.php 2004-02-06
15:31:14.000000000 +1100
@@ -71,8 +71,8 @@
foreach ($groups as $groupName) {
$query = "select count(*)
from `users_objectpermissions`
- where `groupName` = ? and objectId = ?
- and objectType = ? and permName = ?";
+ where `groupName` = ? and `objectId` = ?
+ and `objectType` = ? and `permName`
= ?";

$bindvars = array($groupName, $objectId,
$objectType,
$permName);

Discussion

  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    Thank you for this, I applied on BRANCH-1-8. Consider
    joining the dev team if you come up with such fixes
    frequently :)

     
  • Philippe Cloutier

    • summary: Bug (& patch) in userslib.php --> Bug (& patch) in userslib.php
    • status: open --> open-fixed
     
  • C. David Wilde

    C. David Wilde - 2004-03-03

    Logged In: YES
    user_id=46143

    Heh, I wish I would have checked here first :)

    I just spent an hour fixing this bug, just downloaded the
    gentoo package for 1.8 today. I'm not sure if this missed
    BRANCH or what, but on my gentoo system the bug is still there.

    Thanks.

     
  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    :(
    No, the bug is still opened because we didn't do any release
    since the fix was applied. It will go in 1.8.1.

     
  • Philippe Cloutier

    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks