#1073 Wiki links partly broken with leading space(s)

All_versions
closed-accepted
nobody
3
2005-03-17
2003-11-26
No

If you use leading spaces and then place a link in, it
recognizes it as a wiki link and places a ? after the
text, but does not provide an actual link to create a
new page.

* ((test))

Will generage a page that looks like
* test?

While
* ((test))

works correctly, and generates the ? and the link.

Discussion

  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    Note that in the first message the leading space was
    truncated, and the "*" is facultative, actually you will
    also get the bug with only
    "space"WikiWord
    or
    "space"((Forcedwikilink)

    So the problem is that the automonospaced parsing is partial
    while is should be nonexistent. This will only cause a bug
    for non-existent pages.

    I reported this at WikiDev, thanks Mark.

     
  • Philippe Cloutier

    • priority: 5 --> 3
    • summary: ((wikipage)) style links don't work with leading spaces --> Wiki links partly broken with leading space(s)
    • status: open --> open-accepted
     
  • Philippe Cloutier

    • milestone: 350658 --> 374908
     
  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    Someone got a pointer to the problem. If I write line

    ((Test)) now ''other'' {img
    src="http://ido.ath.cx/http://localhost/Photo,jpg.jpeg"} stuff

    I get as HTML output

    <br/><font
    face="courier">&nbsp;Test<a&nbsp;href='tiki-editpage.php?page=Test'&nbsp;class='wiki'>?</a>&nbsp;now&nbsp;<i>other</i>&nbsp;<img&nbsp;alt="Image"&nbsp;src="&quot;http://ido.ath.cx/http://localhost/Photo,jpg.jpeg&quot;"&nbsp;border="0"&nbsp;&nbsp;/>&nbsp;stuff&nbsp;</font><br/>

    The basic function of automonospaced text is to convert
    spaces to "&nbsp;". Is seems the problem is that the
    conversion is done too late, in this case after the Wiki
    links parsing.
    A correction to parse_data()'s logic needs to be done.

     
  • Philippe Cloutier

    • milestone: 374908 --> All_versions
     
  • Bush

    Bush - 2004-08-06

    Logged In: YES
    user_id=1099137

    Here is the fix:

    tikiwiki-1.8.4/lib/tikilib.php : line 4411

    replace this line:

    $line = '<font face="courier">' . str_replace(' ', '&nbsp;',
    substr($line, 1)). '</font>';

    with:

    $line = '<font face="courier">' . preg_replace("'(?!<.*?)
    (?![^<>]*?>)'", "&nbsp;", $line) .'</font>';

     
  • bertrand Gugger

    bertrand Gugger - 2005-03-17
    • status: open-accepted --> closed-accepted
     
  • bertrand Gugger

    bertrand Gugger - 2005-03-17

    Logged In: YES
    user_id=379264

    Hello,
    This is a broadcast message for all open bugs left before 2004/01/05.
    We hope it was checked but no bug update took place.
    The bug you reported may have been fixed.
    Additionally, if you are using an older form of TikiWiki,
    it is highly recommended you update at least to 1.8.5
    with new security fixes.

    So we open a procedure over the 2 next weeks:
    Please, check your bug or request.
    If you feel it's not relevant anymore, then close it.
    But, if you mind it's still current,
    we invite you to open a new fresh request.

    At the end of this period,
    an automatic cleaning with notifications will take place.

    Tikily yours,
    --
    Tikiwiki Bugs Cleaners
    (contact ---> toggg)

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks