#1038 SPLIT() gives no line breaks in columns

v1.8
closed-fixed
zaufi
6
2004-03-05
2003-11-17
Pontus
No

When using SPLIT() to divide a Wiki page in columns, the
newline character is not replaced by a <br> tag resulting
in no line breaks in the text when the page is viewed.

Discussion

  • Philippe Cloutier

    • assigned_to: nobody --> zaufi
    • status: open --> pending-fixed
     
  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    Hi, I don't exactly know what happened but I would think
    that this is fixed since zaufi commited important changes to
    {SPLIT} on 24th and 25th of october, while 1.7.4 release
    happened the 26th.
    Try to reproduce this on tw.o, if it works reopen this.

     
  • Pontus

    Pontus - 2003-11-20

    Logged In: YES
    user_id=440341

    I tested it again in the sandbox of then TikiWiki.org site and it
    does not work.

    I inserted the following snippet:

    {SPLIT()}Testing split with
    line
    break
    ---
    This is column2 with
    line
    break
    {SPLIT}

    This does not give me any line breaks. The Wiki page just
    spits out "Testing split with line break" and "This is column2
    with line break" in two columns, but with no line breaks.

    I'm using IE6 on WinXP.

     
  • Pontus

    Pontus - 2003-11-20
    • status: pending-fixed --> open-fixed
     
  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    I tested on tw.o... Looks like this is a bug indeed.
    Hopefully zaufi will get some time to comment this.

     
  • Philippe Cloutier

    • status: open-fixed --> open-accepted
     
  • zaufi

    zaufi - 2003-11-20
    • milestone: 350658 --> 320287
     
  • zaufi

    zaufi - 2003-11-20

    Logged In: YES
    user_id=806285

    the answer is:
    `cvs annotate lib/tikilib.php| grep inTable`
    1.356 (chris_ho 17-Nov-03): $inTable = 0;

    i.e. smbd (chris_ho) broke wiki parser (with strange commit) so it
    prevent to insert <br>s inside a tables... and SPLIT as all may
    guess generate exactly <table>...
    I'm with pleasure remove this code if others have no objections...
    bcouse I prefer to have working SPLIT than smth that I don't
    understand... (there is no comments near this strange code WHAT
    THE HELL FOR IT NEEDED)...

     
  • Dennis Daniels

    Dennis Daniels - 2004-01-05
    • milestone: 320287 --> 316038
     
  • Dennis Daniels

    Dennis Daniels - 2004-01-05

    Logged In: YES
    user_id=403318

    confirmed in cvs

     
  • Philippe Cloutier

    • milestone: 316038 --> 356877
    • assigned_to: zaufi --> chris_holman
    • priority: 5 --> 6
     
  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    I'm assigning to chris, you must at least give a comment
    about that change, I'm no coder but zaufi has to understand
    what you did. We need you on IRC chris. If there's no answer
    please zaufi go on with your change.

     
  • Chris Holman

    Chris Holman - 2004-01-08

    Logged In: YES
    user_id=205628

    I cant get access to IRC at work. Network policy.

    I agree that I've been a "bad boy" by not commenting my
    check-in. :-)

    The change was made to ensure tables are rendered correctly
    when using the return character to delimit table
    rows(Admin/Wiki Feature). An unwanted break tag was being
    inserted in the table cells.

    I have no immediate solution that will fix both cases. If
    the Increment/decrement calls are commented out(these are a
    little flakey anyway)
    [code snip]
    // check if we are inside a table, if so, ignore monospaced
    and do
    // not insert <br/>
    //$inTable += substr_count($line, "<table");
    //$inTable -= substr_count($line, "</table");
    [/code snip]
    this will fix the SPLIT problem until a better solution can
    be found.

    Appologies to all for the confusion,
    Chris

     
  • Philippe Cloutier

    Logged In: YES
    user_id=738765

    I'm unassigning from chris since he has no solution and to
    zaufi assuming he may find something :?
    Hopefully

     
  • Philippe Cloutier

    • assigned_to: chris_holman --> zaufi
     
  • Philippe Cloutier

    • milestone: 356877 --> v1.8
     
  • Damian Parker

    Damian Parker - 2004-03-05

    Logged In: YES
    user_id=458483

    Corrected in CVS closed

     
  • Damian Parker

    Damian Parker - 2004-03-05
    • status: open-accepted --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks