Menu

#71 Emoticons within words left in rough shape

open-later
nobody
None
2
2000-08-18
2000-07-28
Anonymous
No

I know at one point emoticons were changed to not show up if within words, but the change made won't display them if next to any letters or digits without a space inbetween, including other emoticons. Perhaps a check could be put in to not show them if there's a letter that's not part of another emoticon? i.e. :):):) with no spaces doesn't show correctly even if it comes from an AIM client. This just makes stuff look messy, I think, and I keep forgetting to put in a space between them myself and they don't show up.

Discussion

  • daron spektor

    daron spektor - 2000-08-18

    We used to not require spaces between emoticons and words, but it caused bad things. Consider the following message:
    "what do you want your username:password to be?"
    TiK would display that as
    "what do you want your username(tounge sticking out)assword to be?"
    Windows AIM does not suffer from this problem because it only parses long emoticons, such as :-p. We may include some regexp refinements allowing for exceptions to the space requirement, but that's definitely not a high priority for 0.90. Who knows, though? Maybe it will make it in.

     
  • daron spektor

    daron spektor - 2000-08-18
    • priority: 5 --> 2
    • status: open --> open-later
     
  • Mark Doliner

    Mark Doliner - 2000-12-24

    Let me know if I'm wrong in any of this...
    Around line 136 of the CVS ui.tik, it starts going through looking at each word for HTML tags and smileys and stuff. The last thing done in the foreach loop is to check for smileys. That's where I get a little lost. I know there's a list of smilies ($::TIK(spatlist)?), and that it regexp's it with the current word ($e), but it seems like that alone would show smilies if they were in a word, unless it adds spaces to each side?

    It seems like people would more often intend to put the smiley in the middle of a word than they would intend to have the colons and braces and stuff show up as colons and braces and stuff.

     
  • Alfred Ellis

    Alfred Ellis - 2001-02-25

    Logged In: YES
    user_id=21617

    In tik.tcl, find the line that looks like this within the
    proc tik_parse_emoticons:

    lappend ::TIK(spatlist) "(^|\\s)($e)($|\\s)"

    and change it to:

    lappend ::TIK(spatlist) "($e)"

    if you want to get rid of spaces.

     

Log in to post a comment.

MongoDB Logo MongoDB