#2 All-language patch


Attached is a patch I created which adds the following to the thoggen
trunk from yesterday:
- An "All languages" checkbox, which allows you to rip all languages
instead of one [1]
- Change ".ogg" to ".ogv" as per Xiph.org standard [2]

I've created this patch by doing "svn diff > multi-lang.diff"
in the trunk/src directory. Also, I've tried mailing this patch, but attachments are not allowed on the list. So, I'm filing it here for later reference.


  • A. Bram Neijt

    A. Bram Neijt - 2007-12-07

    multi-lang patch, made in trunk/thoggen/src/

  • Onkar Shinde

    Onkar Shinde - 2007-12-08

    Logged In: YES
    Originator: NO

    This patch is working for me. I have tested ripping only first 5 minutes of my Incredibles DVD and it ripped English & Chinese audio streams. I am able to select one of the audio language in Totem. Simply wonderful. :-)

    I have modified the patch a little bit to eliminate three pointer related warnings I have observed while compiling. I am not sure if I can attach another file. If I am not able to I will just put those changes here.

  • Onkar Shinde

    Onkar Shinde - 2007-12-08

    Logged In: YES
    Originator: NO

    I am not able to attach another file. Following are changes I made.

    th-job.c, line 2185
    curbuf = g_atomic_pointer_get ((gpointer *) job_current_buf_addr);

    th-job-config-dialog.c, line 471,472
    gtk_widget_set_sensitive (jcd->priv->lang_combobox, !gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON(cbox)));
    g_object_set (jcd->priv->job, "audio-all", gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON(cbox)), NULL);

  • Tim Müller

    Tim Müller - 2007-12-23

    Logged In: YES
    Originator: NO

    Committed, thanks for the patch:

    2007-12-23 Tim-Philipp Müller <tim at centricular dot net>

    patch by: Bram Neijt <bneijt@gmail.com>

    * src/th-job-config-dialog.c: (job_config_dialog_language_changed),
    * src/th-job-config-dialog.glade:
    * src/th-job.c: (PROP_AUDIO_ALL), (job_set_property),
    (job_get_property), (job_class_init), (job_create_pipeline):
    Add checkbox that allows the user to rip all available audio tracks
    (one per language, that is). Closes: #1846411

  • Tim Müller

    Tim Müller - 2007-12-23
    • status: open --> closed-accepted

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

No, thanks