tftpy-general

[tftpy-general] issue with divide by zero in tptpy-client.py

[Vanheesbeke S. <Ste...@va...>]

Hi,
 
When doing some file transfers with very small files (few bytes), a divide by zero exception occurs when calculating the transfer rate.
 
Easy fix at the end of the download function :
 
if duration == 0:
   logger.info("Average rate not determined")
else:
   bps = (self.bytes * 8.0) / duration
   kbps = bps / 1024.0
   logger.info("Average rate: %.2f kbps" % kbps)

Instead of the last 3 lines of code.
 
When using the patch to download files (from Lorenz Schori), this must be changed in the upload function to.
 
 
Stefaan
 
 
 

Re: [tftpy-general] issue with divide by zero in tptpy-client.py

[Michael P. S. <mso...@di...>]

On Sat, May 17, 2008 at 6:23 PM, Vanheesbeke Stefaan
<Ste...@va...> wrote:
> Hi,
>
> When doing some file transfers with very small files (few bytes), a divide
> by zero exception occurs when calculating the transfer rate.

Thanks for telling me. I've opened bug 1966207 for this.

> When using the patch to download files (from Lorenz Schori), this must be
> changed in the upload function to.

I'm not aware of any patch. Enlighten me.

Mike