Menu
▾
▴
1 Attachments
#913 \partcombine doesn't handle rests correctly when its arguments have different lengths
Originally created by: *anonymous
Originally created by: v.villenave
Originally owned by: v.villenave
% Obviously related to Issue 261, but slightly different:
% In the following example, the second argument is
% shorter than the first one, but the rest is placed as if
% there were another voice below it.
% Like in Issue 261, the problem disappears if the second
% argument is given before the first one.
{ c'1
\partcombine { d' d' d' r } { d' c' c' }
c' }
Originally posted by: PhilEHol...@googlemail.com
As of now, the final part of the comment above is wrong: the rest is always voiced, no matter the order of the music.
Having said that: I would be tempted to mark this as invalid: surely the normal approach is to give the partcombiner music of equal lengths?
Originally posted by: v.villenave
I see your point; OTOH, LilyPond has always regarded things like
<< {d4} \\ {c1 c c c} >>
as valid input code.
Diff:
https://codereview.appspot.com/267790043/
Is this really patch-new? I cannot see any Rietveld issue to test against.
I think Trevor and Simon found that comments can disappear and reappear when the title is changed. Can't remember the details, though.
I'm pretty sure I pasted the link into the comment box before setting patch:new. I notice there is no comment about the transition to patch:new either.
https://codereview.appspot.com/267790043/
Dan Eble wrote Tuesday, September 08, 2015 10:48 AM
It's easy to forget to hit Save, as it's usually off the bottom of the screen. That might explain it.
Trevor
Passes make, make check and a full make doc.
Patch on cointdown for Septemeber 14th
Patch counted down - please push
Pushed to staging:
commit 7ff6dd85ed40475f01a0b2847354aa1d486f053b
Author: Dan Eble nine.fierce.ballads@gmail.com
Date: Mon Sep 7 18:14:14 2015 -0400