Menu
▾
▴
#732 Alignment problems when vertically stacking horizontally centered stencils.
Originally created by: *anonymous
Originally created by: v.villenave
Originally owned by: k-ohara5...@oco.net
% In the following example:
\version "2.12.0"
\markup{\concat \left-align { AAA BB C }}
\markup{\concat \center-align { AAA BB C }}
\markup{\concat \right-align { AAA BB C }}
% it's the right end of first markup that's aligned with the alignment
% point of the second one, and similarly the right end of the second
% markup that's aligned with the alignment point of the third markup.
(Mats, http://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00593.html)
% This leads to problems with compound time signatures:
\markup \line {
\center-column { \line {a b} \line {c} }
\vcenter {"+"}
\center-column { \line {a b} \line {c} }
}
(Reinhold,
http://lists.gnu.org/archive/html/bug-lilypond/2008-11/msg00117.html)
% Reinhold has proposed a patch:
http://lists.gnu.org/archive/html/lilypond-devel/2008-11/msg00417.html
Originally posted by: v.villenave
Issue 882 has been merged into this issue.
Originally posted by: percival.music.ca@gmail.com
Since this has a patch and it's been a year, perhaps another poke at lilypond-devel
would be good?
Labels: Patch
Owner: reinhold.kainhofer
Cc: -reinhold.kainhofer
Originally posted by: percival.music.ca@gmail.com
Reinhold removed his patch because it broke other stuff.
Labels: -Patch
Originally posted by: percival.music.ca@gmail.com
Reinhold is no longer working on this issue.
Owner: ---
Status: Accepted
Originally posted by: reinhold...@gmail.com
Patch up for review:
http://codereview.appspot.com/4798050
Labels: Patch-new
Owner: reinhold...@gmail.com
Status: Started
Originally posted by: pkx1...@gmail.com
Passes Make - two reg tests showed differences (attached) but these are trivial I think.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
LGTM
It is just a few days past that I have _again_ been bitten by this bug when writing new code. IIRC, the last patch was postponed indefinitely since it affected figured bass in bad ways. There are few people using figured bass more than Reinhold, so I consider it likely that he got this aspect reasonably tested before proposing his new patch.
If he confirms, I'd be more than happy to merge this finally.
Originally posted by: reinhold...@gmail.com
At least the regtests didn't give any differences for figured bass or fret diagrams... (I got the same two differences as James, but I can't really see the difference, as it appears just a few points here and there are added).
Originally posted by: dak@gnu.org
LGTM then. Personally, it has been annoying me long enough...
Originally posted by: reinhold...@gmail.com
Pushed as commit [ra43a9465fda1728a64fae3619c3f936589dbbdf0]
Labels: -Patch-review fixed_2_15_7
Status: Fixed
Originally posted by: PhilEHol...@googlemail.com
(No comment was entered for this change.)
Status: Verified
Originally posted by: k-ohara5...@oco.net
The original problem is still there in version 2.17. The specific example given above is non-overlapping, but
\markup{\concat \right-align { A BBBB C }}
shows that the space is put in the wrong places.
The patch improved the function general-column-align, repairing the problem withc ompound time signatures. But it also changed markup.scm:stack-stencil-line in an attempt to space out the original example.
This second change prevented backspacing with negative \hspace, see
<http://lists.gnu.org/archive/html/bug-lilypond/2012-11/msg00062.html> ,
and does not seem to improve right/center-aligned text. The old behavior made more sense to me.
I suggest reversing the change to markup.scm:stack-stencil-line
Labels: -Priority-Medium -fixed_2_15_7
Owner: ---
Cc: reinhold...@gmail.com
Status: Accepted
Originally posted by: k-ohara5...@oco.net
The test 'markup-center-align-nocollision.ly' fails as shown in the image. Right-aligned text is represented internally the same way as text following a backspace
\markup {"a" \hspace #-2 "b" "ccccc" \translate #'(-2 . 1) "ddd"}
and there are users who depend on such back-spaced text *not* getting its full space.
(See the mutopiaproject footer, for example.)
The portion of the test covering compound time-signatures, however, succeeds.
I will revise this regression test after the patchy check.
http://codereview.appspot.com/6855077
Labels: Patch-new
Owner: k-ohara5...@oco.net
Cc: -reinhold...@gmail.com
Status: Started
Originally posted by: pkx1...@gmail.com
Patchy says passes make and make tests... reg test diff attached.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20121116, please push.
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
The part of 'markup-center-align-nocollision.ly' that tested the part of the patch we are reversing was failing, of course, so this patch removes that part of the test.
'morgenleid.ly' uses \hspace #-3 as a backspace, so it serves as a test that we solve the problem linked in comment 12. After this patch, the tempo indication is moved left, as the author of the .ly file clearly intended with his input.
These changes to markup only do not change the signature files that `make check` uses to find changes. Until we think of a better way those of use making changes that do not show up on `make check` will just have to point out such changes manually.
Labels: -Patch-push Patch-new
Originally posted by: k-ohara5...@oco.net
http://codereview.appspot.com/6855077
Originally posted by: pkx1...@gmail.com
Patchy says passes make and make tests... reg test diff attached.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20121203, please push.
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
Commit [r441aac921f351209aa651b1a56f6b93145687867] partially reverses the original fix
The first line of the original bug report should now overlap (so that the similar mechanism for back-spacing works in other situations) but the line with ab/c + ab/c remains legibly spaced-out.
Labels: -Patch-push Fixed2_17_9
Status: Fixed
Originally posted by: tdanielsmusic
(No comment was entered for this change.)
Labels: -Fixed2_17_9 Fixed_2_17_9
Originally posted by: k-ohara5...@oco.net
I had forgotten to push to the server, but did now, with commit
[rbad0e5f6c8a3e5a40284e4120cb9753b77a8d7b3]
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified