LilyIssues / Issues / #704 whole notes tremolos collide with accidentals

Google Importer - 2011-08-20

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: -type-Collision Type-Ugly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-26

Originally posted by: mts...@gmail.com

First stab at chord tremolo avoiding accidentals

http://codereview.appspot.com/6485070

Labels: Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-27

Originally posted by: mts...@gmail.com

First stab at chord tremolo avoiding accidentals

http://codereview.appspot.com/6485070

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-27

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes tests. 523

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-27

Originally posted by: pkx1...@gmail.com

Ignore the '523' I was seeing if accept-patchy.py could handle multiple tracker items. It couldn't :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-28

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-countdown
Owner: mts...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-29

Originally posted by: grenoui...@lilynet.net

Build results are available at

http://grenouille.lilynet.net/patches-tests/704/test-results

13:56:31 (UTC) Begin LilyPond compile, previous commit at     [r1cdcb2f73f35834fef5cbbc2a6647a11ae468f85]
13:56:38 From git.savannah.gnu.org:/srv/git/lilypond
   1cdcb2f..66a7c3e master     -> master
13:56:49 Merged master, now at:    [r66a7c3e925cbc1a34eaad04f80d4bc42ad9834ac]
13:56:51     Success:        sudo -u lilybuild ./autogen.sh --noconfigure
13:57:28     Success:        sudo -u lilybuild /home/lilybuild/master/configure --disable-optimising
13:57:38     Success:        sudo -u lilybuild nice make clean
14:13:02     Success:        sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
14:34:46     Success:        sudo -u lilybuild nice make test-baseline -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1

02:04:42 Issue 704: whole notes tremolos collide with accidentals
02:04:42 Issue 704: Testing patch issue6485070_2001_diff
02:04:43     Success:        sudo -u lilybuild git apply --index /home/jmandereau/lily-test-patches/issue6485070_2001.diff
02:04:44     Success:        sudo -u lilybuild ./autogen.sh --noconfigure
02:05:12     Success:        sudo -u lilybuild /home/lilybuild/master/configure --disable-optimising
02:05:21     Success:        sudo -u lilybuild nice make clean
02:20:39     Success:        sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
02:43:42     Success:        sudo -u lilybuild nice make check -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1

Related

Issues: #704

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-30

Originally posted by: ColinPKC...@gmail.com

Counted down to 20120830, please pus

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-08-31

Originally posted by: mts...@gmail.com

Pushed as [rd8dfa746ead381a80901106b9c9b079dc9b5d004].

Labels: Fixed_2_17_2
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-09-11

Originally posted by: Elu...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-10-03

Originally posted by: k-ohara5...@oco.net

For most cases, the problem remains.

{ \repeat tremolo 16 { c'32 eses' } \repeat tremolo 16 { a'32 cis'' } \repeat tremolo 16 { a'32 disis' } << \repeat tremolo 16 { a''32 bes'' } \\ \repeat tremolo 16 { d'32 bes } >> }

version 2.17.26 gives the attached image.

The documented effect of \override Beam #'gap = #0.2 was lost when the patch above was committed (issue 3115).

Labels: -Priority-Medium -Patch-push -Fixed_2_17_2
Owner: ---
Status: Accepted

Related

Issues: ~~#3115~~

Last edit: Simon Albrecht 2015-09-28

tremolo.png
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-10-07

Originally posted by: dak@gnu.org

I don't think it makes sense fixing the collision in the current state, in particular not when the solution involves magic numbers.

The reason is that whole-note tremoli are rarely used, and when they are, the tremolo beams are, as far as I remember, centered between the note heads and with a beam direction corresponding to the pitch difference.

What LilyPond produces is more or less an absurdity, and it seems a waste of time to properly space this absurdity. First we should get the beams where they are supposed to be, and _then_ fix collisions.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-10-07

Originally posted by: PhilEHol...@googlemail.com

A major defect in the beam placement is their angle - they should not be always horizontal. I attach 3 images: Gould on whole note tremolos, the Sibelius concept (quite close to Gould, actually) and current Lilypond (2.17.28 just released, without the revert, I think).

GouldWholeTrem.png

WholeNoteTrems.png

WholeNoteTremsSib.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-10-07

Originally posted by: dak@gnu.org

Ok, so what I remembered was not accurate: whole note tremoli don't need to be between the noteheads (though Gould permits it as a variant). Still, we are not sloping them right.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-10-07

Originally posted by: dak@gnu.org

Personally, I don't like the asymmetric look that comes from the imaginary stem attachments being to the side of the whole note heads. If we accept this as the state to achieve, then it would seem like our best bet would be to simulate having stems everywhere except when actually typesetting them. Any issues regarding accidentals should then either be moot, or we would have to address them for non-whole notes equally.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-10-07

Originally posted by: PhilEHol...@googlemail.com

I agree concerning the non-symmetrical look of the tremolo bars. My preference would be for them to be symmetrically placed between the notes, unless it's really a lot simpler to view semi-breves as having stems for the purposes of tremoli.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-07-20

Originally posted by: pkx1...@gmail.com

Is this the same/related problem as the newer issue 3143?

Related

Issues: #3143

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -2,10 +2,11 @@

 *Originally created by:* [v.villenave](http://code.google.com/u/v.villenave/)

-% This one has been around for a while.
+This one has been around for a while.
+The tremolo beams collide with the accidental:

-% the tremolo beams collide with the accidental
-
+~~~~
+:::TeX
 \version "2.11.64"

-\repeat tremolo 16 \{c''32 dis''\}
+\repeat tremolo 16 { c''32 dis'' }

Needs: -->
Patch: -->

whole notes tremolos collide with accidentals

Issue Tracker for LilyPond

Searches

Help

#704 whole notes tremolos collide with accidentals

Related

Discussion

Related

Related

Related