Menu

#5969 Clean up and fix glyph contour generation nits.

Started
None
new
2020-05-10
2020-05-09
No

There are two bugs:

  • Glyphs with multiple contours (e.g. "O" or "i") should compute the
    contours separately

  • Contours can wraparound to the start. This leads to OOB reads and/or
    incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043

Discussion

  • Han-Wen Nienhuys

    this is split off from https://codereview.appspot.com/569700043/ .

    Since that one is in "push" status already, I suggest to fasttrack this, if Werner is agrees with this change.
    
     
  • David Kastrup

    David Kastrup - 2020-05-09

    That sounds like it would be more sensible to remove that issue from "push" until the consequences have been figured out rather than to fasttrack everything.

     
    • Anonymous

      Anonymous - 2020-05-09

      I'd have to agree, else it may seem we're backdooring the process.

       
      • Anonymous

        Anonymous - 2020-05-09

        Looks like what Han-wen did was push that patch anyway.

         
        • Han-Wen Nienhuys

          I don't think this is true. Reference?

           
  • Anonymous

    Anonymous - 2020-05-09

    Passes make, make check and a full make doc.

    Patch set 1 diffs (~6mb)

    https://cloud-u8zj2dc4b.yourownnet.eu/s/AkGBgPZEpb5nrLH

     
  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.