Menu

#5963 Remove define causing a warning

Fixed
Enhancement
2020-05-10
2020-05-04
No

Remove define causing a warning

These lines were added in commit 25beb8d01b in 2008 to provide
compatibility with GCC 3.4 which clearly does not support C++11.
(The warning is visible since commit b96b6334c0 which put system
headers last, so that the define is already provided transitvely.)

http://codereview.appspot.com/561790043

Discussion

  • Anonymous

    Anonymous - 2020-05-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-05-05

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-05-07
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-05-07

    Patch on countdown for May 9th

     
  • Anonymous

    Anonymous - 2020-05-09
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-05-09

    Patch counted down - please push

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-10
    • labels: --> Fixed_2_21_2
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-10
    commit 3ba316af1f73395294df29ee34f3472df31b7e00
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Mon May 4 16:19:00 2020 +0200
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Sat May 9 20:04:45 2020 +0200
    
        Issue 5963: Remove define causing a warning
    
        These lines were added in commit 25beb8d01b in 2008 to provide
        compatibility with GCC 3.4 which clearly does not support C++11.
        (The warning is visible since commit b96b6334c0 which put system
        headers last, so that the define is already provided transitvely.)