LilyIssues / Issues / #5953 Further cleanup/regularisation of Callback_wrapper classes and trampolines

#5953 Further cleanup/regularisation of Callback_wrapper classes and trampolines

Status: Fixed

Owner: David Kastrup

Labels: Fixed_2_21_2 (37)

Needs:

Patch:

Type: Enhancement

Updated: 2020-05-07

Created: 2020-05-01

Creator: David Kastrup

Private: No

Further cleanup/regularisation of Callback_wrapper classes and trampolines

Contains two commits:

Callback_wrapper:: move trampolines and make_smob to Callbacks class

Make Callback_wrapper a class template

Templating Callback_wrapper on the wrapped argument list avoids a lot
of code repetition.

http://codereview.appspot.com/553980044

Discussion

Anonymous - 2020-05-02

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-02

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-04

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-04

Patch on countdown for May 6th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-07

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-07

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-07

labels: --> Fixed_2_21_2

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Issue 5953/1: Make Callback_wrapper a class template
author  David Kastrup <dak@gnu.org> 
    Wed, 29 Apr 2020 23:12:10 +0100 (00:12 +0200)
committer   David Kastrup <dak@gnu.org> 
    Thu, 7 May 2020 10:28:49 +0100 (11:28 +0200)
commit  6a95c1d34f7cb7e4fb67d2279a917c9ef3cfdd6b

Issue 5953/2: Callback_wrapper:: move trampolines and make_smob to Callbacks class
author  David Kastrup <dak@gnu.org> 
    Fri, 1 May 2020 20:12:10 +0100 (21:12 +0200)
committer   David Kastrup <dak@gnu.org> 
    Thu, 7 May 2020 10:28:49 +0100 (11:28 +0200)
commit  3c13d9d745f9983deac6d217169764b527469d6b