Menu

#5952 Use axis indexing to clarify different behaviors for X/Y skylines

Fixed
2020-05-08
2020-05-01
No

Use axis indexing to clarify different behaviors for X/Y skylines

https://codereview.appspot.com/573770043

Discussion

  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-05-02
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-05-02

    Passes make, make check and a full make doc.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-02
    • summary: Remove if/else for shift/raise --> Use axis indexing to clarify different behaviors for X/Y skylines
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,3 @@
    -Shift (horizontal) and raise (vertical) movements are commutative
    +Use axis indexing to clarify different behaviors for X/Y skylines
    
     https://codereview.appspot.com/573770043
    
     
  • Anonymous

    Anonymous - 2020-05-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-05-04

    Patch on countdown for May 6th

     
  • Anonymous

    Anonymous - 2020-05-07
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-05-07

    Patch counted down - please push

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-08
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-08
    commit 766070bdbcc1da6ac123f7003db5bf3ba073defd
    Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
    AuthorDate: Fri May 1 19:59:30 2020 +0200
    Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
    CommitDate: Fri May 8 09:14:04 2020 +0200
    
        Use axis indexing to clarify different behaviors for X/Y skylines
    
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-08
    • labels: --> Fixed_2_21_2