Menu

#5945 Add flag to NoteColumn using Axis_group_interface.

Fixed
2020-05-02
2020-04-27
No

The NoteColumn is an axis-group, for both X and Y axes.

https://codereview.appspot.com/555770044

Discussion

  • Anonymous

    Anonymous - 2020-04-27
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Anonymous

    Anonymous - 2020-04-27

    Fails make

    ...
    Making lily/out/tuplet-iterator.o < cc
    Making lily/out/figured-bass-engraver.o < cc
    Making lily/out/paper-def.o < cc
    Making lily/out/performer-group.o < cc
    Making lily/out/rhythmic-column-engraver.o < cc
    /home/james/lilypond-git/lily/figured-bass-engraver.cc: In member function 'void Figured_bass_engraver::process_music()':
    /home/james/lilypond-git/lily/figured-bass-engraver.cc:376:44: warning: conversion to 'std::vector<int>::value_type {aka int}' from 'vsize {aka long unsigned int}' may alter its value [-Wconversion]
                 junk_continuations.push_back (i);
                                                ^
    Making lily/out/volta-engraver.o < cc
    /home/james/lilypond-git/lily/rhythmic-column-engraver.cc: In member function 'void Rhythmic_column_engraver::process_acknowledged()':
    /home/james/lilypond-git/lily/rhythmic-column-engraver.cc:108:11: error: 'Axis_group_interface' has not been declared
               Axis_group_interface::add_grob (note_column_, flag_);
               ^~~~~~~~~~~~~~~~~~~~
    /home/james/lilypond-git/build/../stepmake/stepmake/c++-rules.make:4: recipe for target 'out/rhythmic-column-engraver.o' failed
    make[1]: *** [out/rhythmic-column-engraver.o] Error 1
    make[1]: *** Waiting for unfinished jobs....
    /home/james/lilypond-git/build/../stepmake/stepmake/generic-targets.make:6: recipe for target 'all' failed
    make: *** [all] Error 2
    
     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-04-28
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-04-28

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-04-30
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-04-30

    Patch on countdown for May 2nd

     
  • Anonymous

    Anonymous - 2020-05-02
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-05-02

    Patch counted down - please push

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-02
    • labels: --> Fixed_2_21_2
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-02
    commit 0b45d764dcbc704713c8a32186561305e58d5659
    Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
    AuthorDate: Mon Apr 27 10:31:56 2020 +0200
    Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
    CommitDate: Sat May 2 09:25:34 2020 +0200
    
        Add flag to NoteColumn using Axis_group_interface.
    
        The NoteColumn is an axis-group, for both X and Y axes.