LilyIssues / Issues / #5944 Put system headers after lilypond headers throughout

Anonymous - 2020-04-27

Needs: -->

Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

fails make

...
Making lily/out/context-specced-music-iterator.o < cc
Making lily/out/listener.o < cc
Making lily/out/pango-font.o < cc
Making lily/out/note-head.o < cc
Making lily/out/relative-octave-music.o < cc
Making lily/out/semi-tie.o < cc
/home/james/lilypond-git/lily/pango-font.cc: In member function 'Stencil Pango_font::pango_item_string_stencil(const PangoGlyphItem*) const':
/home/james/lilypond-git/lily/pango-font.cc:234:28: error: invalid use of incomplete type 'PangoFcFont {aka struct _PangoFcFont}'
   FcPattern *fcpat = fcfont->font_pattern;
                            ^~
In file included from /usr/include/pango-1.0/pango/pangoft2.h:29:0,
                 from /home/james/lilypond-git/lily/include/pango-font.hh:26,
                 from /home/james/lilypond-git/lily/pango-font.cc:22:
/usr/include/pango-1.0/pango/pangofc-font.h:47:16: note: forward declaration of 'PangoFcFont {aka struct _PangoFcFont}'
 typedef struct _PangoFcFont      PangoFcFont;
                ^~~~~~~~~~~~
/home/james/lilypond-git/build/../stepmake/stepmake/c++-rules.make:4: recipe for target 'out/pango-font.o' failed
make[1]: *** [out/pango-font.o] Error 1
make[1]: *** Waiting for unfinished jobs....
/home/james/lilypond-git/build/../stepmake/stepmake/generic-targets.make:6: recipe for target 'all' failed
make: *** [all] Error 2

Han-Wen Nienhuys - 2020-04-27

revert pango-font.cc

https://codereview.appspot.com/577840051

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-28

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-28

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-30

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-30

Patch on countdown for May 2nd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-02

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-02

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-05-02

labels: --> Fixed_2_21_2

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit b96b6334c00adb398b632aaeefdeaf3a8e6c57c5
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Mon Apr 27 10:22:26 2020 +0200
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Sat May 2 09:26:12 2020 +0200

    Put system headers after lilypond headers throughout

Put system headers after lilypond headers throughout

Issue Tracker for LilyPond

Searches

Help

#5944 Put system headers after lilypond headers throughout

Discussion