LilyIssues / Issues / #5943 Convert stencil to skyline directly

Han-Wen Nienhuys - 2020-04-26

oops.

https://codereview.appspot.com/555760043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-26

Patch does not apply to current master

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-26

Patch: review --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-05-02

rebase

https://codereview.appspot.com/555760043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-02

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-02

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-05-02

rebase; jonas

https://codereview.appspot.com/555760043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-03

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-03

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-04

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-04

Patch on countdown for May 6th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-07

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-05-07

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-05-08

labels: --> Fixed_2_21_2

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit 96b0e346adebe12ac742044c02cc8c2152e89977
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Sat May 2 09:31:13 2020 +0200
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Fri May 8 09:13:08 2020 +0200

    Convert stencil to skyline directly

    Gets rid of more intermediate storage.

    eb3e0449f4 - Convert stencil to skyline directly
      baseline: 78d4ae8627 Thread skyline construction through stencil interpretation
      args: -I carver MSDM
      memory: med diff -1464 (stddevs 202 98, n=3)
      memory: med diff -0.1 % (eb3e0449f4 is leaner)
      time: med diff 0.10 (stddevs 0.09 0.06, n=3)
      time: med diff 0.2 % (eb3e0449f4 is neutral)

and

commit 9e69d5c5e19458bde7a413d7c3e4d3e0ec3060d4
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Fri May 8 09:12:55 2020 +0200
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Fri May 8 09:15:14 2020 +0200

    Convert stencil to skyline directly

    Gets rid of more intermediate storage.

    f7d164b888 - Convert stencil to skyline directly
      baseline: 267e894e79 Thread skyline construction through stencil interpretation
      args: -I carver MSDM
      memory: med diff -1068 (stddevs 84 90, n=5)
      memory: med diff -0.1 % (f7d164b888 is leaner)
      time: med diff -0.18 (stddevs 0.15 0.05, n=5)
      time: med diff -0.4 % (f7d164b888 is neutral)

(the latter applying the changes I requested during review)

Convert stencil to skyline directly

Issue Tracker for LilyPond

Searches

Help

#5943 Convert stencil to skyline directly

Discussion