Menu

#5941 Create skylines directly from glyph outlines.

Fixed
2020-05-08
2020-04-26
No

This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.

Benchmark:

benchmark for arguments: input/regression/mozart-hrn-3.ly
raw data: {'ac8eaa37ee': [2.73, 2.7, 2.73], '893552a691': [2.7, 2.71, 2.71]}
med diff -0.732601 % (893552a691 is faster)

benchmark for arguments: -I carver MSDM
raw data: {'ac8eaa37ee': [52.43, 52.41, 52.17], '893552a691': [52.47, 52.33, 52.18]}
893552a691 - Create skylines directly from glyph outlines.
med diff -0.152643 % (893552a691 is faster)

(for Carver score, the difference is at noise)

https://codereview.appspot.com/561730043

Discussion

  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-04-26
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-04-26

    Patch doesn't apply to current master.

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-05-02
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-05-02

    Passes make, make check and a full make doc.

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-05-03
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-05-03

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-05-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-05-04

    Patch on countdown for May 6th

     
  • Anonymous

    Anonymous - 2020-05-07
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-05-07

    Patch counted down - please push

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-08
    • labels: --> Fixed_2_21_2
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-05-08
    commit 79ec62e686a95bbb8bb8b61a3dcbd702de0abb91
    Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
    AuthorDate: Sat May 2 09:33:36 2020 +0200
    Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
    CommitDate: Fri May 8 09:14:30 2020 +0200
    
        Create skylines directly from glyph outlines.
    
        This avoids creating garbage for the intermediate Scheme data to
        transport the glyph outlines.
    
        a20f8b786e - Create skylines directly from glyph outlines.
          baseline: 267e894e79 Thread skyline construction through stencil interpretation
          args: input/regression/mozart-hrn-3
          memory: med diff 76 (stddevs 77 85, n=3)
          memory: med diff 0.0 % (a20f8b786e is neutral)
          time: med diff 0.02 (stddevs 0.02 0.02, n=3)
          time: med diff 0.6 % (a20f8b786e is neutral)
    
        a20f8b786e - Create skylines directly from glyph outlines.
          baseline: 267e894e79 Thread skyline construction through stencil interpretation
          args: -I carver MSDM
          memory: med diff -19408 (stddevs 134 228, n=5)
          memory: med diff -1.8 % (a20f8b786e is leaner)
          time: med diff -1.14 (stddevs 0.10 0.14, n=5)
          time: med diff -2.3 % (a20f8b786e is faster)