#5940 Split glyph contours in up/down segments for skylines

[Han-Wen Nienhuys]

This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
med diff -0.020000
med diff -0.738007 % (e8212e15e2 is faster)

benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
med diff -0.720000
med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043

[Han-Wen Nienhuys]

rebase

https://codereview.appspot.com/569700043

[Han-Wen Nienhuys]

contours

https://codereview.appspot.com/569700043

[Anonymous]

Patch does not apply to current master.

[Han-Wen Nienhuys]

rebase

https://codereview.appspot.com/569700043

[Anonymous]

Patch does not apply to current master.

[Han-Wen Nienhuys]

rebase

https://codereview.appspot.com/569700043

[Han-Wen Nienhuys]

rebase; drop experimental work

https://codereview.appspot.com/569700043

[Anonymous]

Fails make check

...
Making Documentation/topdocs/out/AUTHORS.txt < texi
Making Documentation/topdocs/out/NEWS.txt < texi
[1]+  Done                    gitk  (wd: ~/lilypond-git)
(wd now: ~/lilypond-git/build)
.
----------------------------------------------------------------------
Ran 1 test in 0.002s

OK
testing /home/james/lilypond-git/scripts/build/output-distance.py 

Please check the logfile

  /home/james/lilypond-git/build/scripts/build/./out/output-distance-test.log

for errors

last 20 lines:
GNU LilyPond 2.21.2
test results in  ./out/test-output-distance
Traceback (most recent call last):
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1561, in <module>
    main ()
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1546, in main
    run_tests ()
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1494, in run_tests
    test_basic_compare ()
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1438, in test_basic_compare
    test_compare_signatures (simple_names)
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1481, in test_compare_signatures
    assert combinations['20-19'][1] < 10.0
AssertionError
/home/james/lilypond-git/build/.././scripts/build/GNUmakefile:9: recipe for target 'local-test' failed
make[2]: *** [local-test] Error 1
/home/james/lilypond-git/build/../GNUmakefile.in:287: recipe for target 'test' failed
make[1]: *** [test] Error 2
/home/james/lilypond-git/build/../GNUmakefile.in:331: recipe for target 'local-check-pre' failed
make: *** [local-check-pre] Error 2

The log file referenced just gives the same errors as the output above.

[Han-Wen Nienhuys]

jonas.

https://codereview.appspot.com/569700043

[Anonymous]

Passes make, make check and a full make doc.

Reg test diffs here (patch 7) ~ 6MB!

https://cloud-u8zj2dc4b.yourownnet.eu/s/qJNCHJzFsmrRM3R

[Han-Wen Nienhuys]

looks like the bugfixes caused minor formatting diffs. I'll separate out the bugfixes so we can be sure.

[Han-Wen Nienhuys]

rebase on bugfix change

https://codereview.appspot.com/569700043

[Anonymous]

Patch does not apply to current master