Okay, so it's not just me hitting that thing. There's a missing dependency in the Documentation build that's probably uncovered by recent performance improvements in LilyPond. I don't think it's this patch. If you didn't prune your tree yet, you may just retry running 'make doc' and hope that internals.texi is processed first. I'll submit a proper fix tomorrow.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
From the logs, it's one of the lilypond-book processes in Documentation, didn't test myself though. Did you try to run 'make doc' on your end? As the change is removing ly:lexer-keywords it could also be that it breaks generation of the internals reference manual.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
From the logs, it's one of the lilypond-book processes in Documentation, didn't test myself though. Did you try to run 'make doc' on your end? As the change is removing ly:lexer-keywords it could also be that it breaks generation of the internals reference manual.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-27
Needs: -->
Patch: new --> needs_work
Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-27
Fails make
...Makinglily/out/lily-lexer.o<ccMakinglily/out/metronome-engraver.o<ccMakinglily/out/warn-scheme.o<cc/home/james/lilypond-git/lily/lily-lexer.cc:47:13:error:'unordered_map'innamespace'std'doesnotnameatemplatetypestaticstd::unordered_map<std::string,int>keytable{^~~~~~~~~~~~~/home/james/lilypond-git/lily/lily-lexer.cc:Inmemberfunction'int Lily_lexer::lookup_keyword(const string&)':/home/james/lilypond-git/lily/lily-lexer.cc:183:20:error:'keytable'wasnotdeclaredinthisscopeautoconst&it=keytable.find(s);^~~~~~~~/home/james/lilypond-git/lily/lily-lexer.cc:183:20:note:suggestedalternative:'mutable'autoconst&it=keytable.find(s);^~~~~~~~mutableMakinglily/out/lexer.o<cc/home/james/lilypond-git/build/../stepmake/stepmake/c++-rules.make:4:recipefortarget'out/lily-lexer.o'failedmake[1]:***[out/lily-lexer.o]Error1make[1]:***Waitingforunfinishedjobs....out/lexer.cc:Inmemberfunction'virtual int yyFlexLexer::LexerInput(char*, int)':out/lexer.cc:6476:21:warning:conversionto'int'from'std::streamsize {aka long int}'mayalteritsvalue[-Wconversion]returnyyin.gcount();~~~~~~~~~~~^~/home/james/lilypond-git/build/../stepmake/stepmake/generic-targets.make:6:recipefortarget'all'failedmake:***[all]Error2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think that would make sense. I already have the promised followup issue removing ly:lexer-keywords in a branch and wanted for staging to get through before I bring it up.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
jonas
https://codereview.appspot.com/549920043
Diff:
This just sits at
and makes my fan spin very loudly.
Okay, so it's not just me hitting that thing. There's a missing dependency in the Documentation build that's probably uncovered by recent performance improvements in LilyPond. I don't think it's this patch. If you didn't prune your tree yet, you may just retry running 'make doc' and hope that internals.texi is processed first. I'll submit a proper fix tomorrow.
@lilypond-pkx could you please try again? The error you saw should now be fixed in
master.Now it just sits at
when running 'make'
From the logs, it's one of the lilypond-book processes in Documentation, didn't test myself though. Did you try to run 'make doc' on your end? As the change is removing ly:lexer-keywords it could also be that it breaks generation of the internals reference manual.
I can repro it now, sorry for the noise.
On Mon, Apr 27, 2020 at 10:34 AM Jonas Hahnfeld
hahnjo@users.sourceforge.net wrote:
Related
Issues: #5923
drop table from lexer class
https://codereview.appspot.com/549920043
unused hdr
https://codereview.appspot.com/549920043
Fails make
add missing header
https://codereview.appspot.com/549920043
Passes make, make check and a full make doc.
Patch on countdown for May 2nd - not comments on Rietveld from David K
Patch counted down - please push
Han-Wen, David, shall we close this as Issue 5946 is now in staging?
I think that would make sense. I already have the promised followup issue removing ly:lexer-keywords in a branch and wanted for staging to get through before I bring it up.