make_draw_bezier_boxes: save work if thickness == 0.0

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5915 make_draw_bezier_boxes: save work if thickness == 0.0

Status: Fixed

Owner: Han-Wen Nienhuys

Labels: Fixed_2_21_1 (43)

Needs:

Patch:

Type: Enhancement

Updated: 2020-04-24

Created: 2020-04-17

Creator: Han-Wen Nienhuys

Private: No

This drop make_draw_bezier_boxes from 0.73% to 0.44% in the profile for
MSDM

https://codereview.appspot.com/551730043

Discussion

Anonymous - 2020-04-18

Passes make, make check and a full make doc.

Reg test diff attached

Screenshot from 2020-04-18 16-53-17.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-04-18

it points to a reduction in memory use which is expected, but i'm surprised the effect is so large.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-21

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-21

Patch on countdown for April 23rd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-23

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-23

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-04-24

labels: --> Fixed_2_21_1

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit fadb710df7ed135d7712ce50fcdfa83a89753213
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Fri Apr 17 20:20:50 2020 +0200
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Fri Apr 24 00:09:01 2020 +0200

    make_draw_bezier_boxes: save work if thickness == 0.0

    This drop make_draw_bezier_boxes from 0.73% to 0.44% in the profile for
    MSDM