Menu

#5907 Rewrite Mutable_properties based on vector<SCM>

Started
None
needs_work
Enhancement
2020-04-14
2020-04-13
No

Rewrite Mutable_properties based on vector<SCM>

Alists use are based on linked lists. They have poor locality, which
introduces more CPU cache misses. Since LilyPond is not multithreaded,
the CPU sits idle during these misses.

This is part a series of experiments to rearchitect property
storage. None of them seem especially promising currently.

https://codereview.appspot.com/575990043

Related

Issues: #5907

Discussion

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-14

    This is part a series of experiments to rearchitect property
    storage. None of them seem especially promising currently.

    Han-Wen, is this already meant for review? If not, I propose to either delete it right away or correct title and description and set it to Needs_work.

     
    • Han-Wen Nienhuys

      set to needs_work is fine.

      On Tue, Apr 14, 2020 at 8:56 AM Jonas Hahnfeld
      hahnjo@users.sourceforge.net wrote:

      This is part a series of experiments to rearchitect property
      storage. None of them seem especially promising currently.

      Han-Wen, is this already meant for review? If not, I propose to either delete it right away or correct title and description and set it to Needs_work.


      [issues:#5907] rebase

      Status: Started
      Created: Mon Apr 13, 2020 08:47 PM UTC by Han-Wen Nienhuys
      Last Updated: Mon Apr 13, 2020 08:47 PM UTC
      Owner: Han-Wen Nienhuys

      https://codereview.appspot.com/575990043


      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlilyissues/issues/5907/

      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

       

      Related

      Issues: #5907

      • Jonas Hahnfeld

        Jonas Hahnfeld - 2020-04-14

        I'll add parenthesis: "I propose to either (delete it right away) or ((correct title and description) and (set it to Needs_work))". So setting to needs_work alone wasn't exactly one of my options.

         
    • Han-Wen Nienhuys

      On Tue, Apr 14, 2020 at 8:56 AM Jonas Hahnfeld
      hahnjo@users.sourceforge.net wrote:

      This is part a series of experiments to rearchitect property
      storage. None of them seem especially promising currently.

      Han-Wen, is this already meant for review? If not, I propose to either delete it right away or correct title and description and set it to Needs_work.

      what does 'delete' mean? Given the related discussion about
      performance,, I think this code is useful to keep around in case
      anyone wants to opimize get_property again.

       
      • Jonas Hahnfeld

        Jonas Hahnfeld - 2020-04-14

        My though was to delete this issue on SF (not talking about Rietveld), which you didn't create for the first upload. Doesn't matter anymore, I've added the missing title and description.

         
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-14
    • summary: rebase --> Rewrite Mutable_properties based on vector<SCM>
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,10 @@
    +Rewrite Mutable_properties based on vector&lt;SCM&gt;
    +    
    +Alists use are based on linked lists. They have poor locality, which
    +introduces more CPU cache misses. Since LilyPond is not multithreaded,
    +the CPU sits idle during these misses.
    +
    +This is part a series of experiments to rearchitect property
    +storage. None of them seem especially promising currently.
    +
     https://codereview.appspot.com/575990043
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-14
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -Rewrite Mutable_properties based on vector&lt;SCM&gt;
    +Rewrite Mutable_properties based on `vector&lt;SCM&gt;`
    
     Alists use are based on linked lists. They have poor locality, which
     introduces more CPU cache misses. Since LilyPond is not multithreaded,
    
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.