Optimize get_path_list.

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5904 Optimize get_path_list.

Status: Fixed

Owner: Han-Wen Nienhuys

Labels: Fixed_2_21_1 (43)

Needs:

Patch:

Type:

Updated: 2020-04-19

Created: 2020-04-13

Creator: Han-Wen Nienhuys

Private: No

It constructed a list just call memv() on it. Memv does the
hare&tortoise algorithm, so it's also unnecessarily slow.

https://codereview.appspot.com/579570043

Discussion

Han-Wen Nienhuys - 2020-04-13

dak

https://codereview.appspot.com/579570043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-15

Description has changed:

Diff:

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-15

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-17

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-17

Patch on countdown for April 19th

(is it worth a new tracker for the 'I'm going to pass on ... ' issue?)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-19

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-19

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-04-19

labels: --> Fixed_2_21_1

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit d48d79b52c28cf9c82d088b2fdf8edbf452d6f94
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Mon Apr 13 18:36:46 2020 +0200
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Sun Apr 19 09:59:34 2020 +0200

    Optimize get_path_list.

    It constructed a list just to call memv() on it. Memv does the
    hare&tortoise algorithm, so it's also unnecessarily slow.