If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-18
Needs: -->
Patch: new --> review
Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-18
Passes make, make check and a full make doc
@hanwen the term 'review' as Jonas says, implies that the patch has been shown to not break against the make, make check and make doc tests for current master (which obviously can be a moveable feast, and is another reason we have this relatively clear patch countdown cycle - as it gives Devs some reasonable chance to not have to perpetually rebase every day because we're pushing to master ad-hoc and their new patches suddenly don't apply)
Some devs prefer to spend their time to check a patch submission once they know it has been 'tested'.
I know this patch cycle has frustrated some devs, but when there are dozens of patches submitted, developers can choose how to plan the limited time they might have and spend it on those patches that are at least shown to have compiled or that are about to be pushed rather than those just submitted and not even tested yet.
As ever, developers can bypass/override this process as they discuss/see fit on the lists
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-21
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-21
Patch on countdown for April 23rd
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-23
Patch: countdown --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-04-23
This seems to be still under discussion, I am setting this back to review for now.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
reserve
https://codereview.appspot.com/583750043
ptr iso. ref
https://codereview.appspot.com/583750043
Diff:
Passes make, make check and a full make doc
notes to self about optimization
https://codereview.appspot.com/583750043
Passes make, make check and a full make doc
On 2020/04/13 18:51:22, hanwenn wrote:
update timings; rebase on interval building.
https://codereview.appspot.com/583750043
No, please don't: As far as I can tell, this now depends on #5911 and skipping James' tests like this is not appropriate.
'new': to be tested
'review': tested and confirmed to build (possibly with reg test differences)
However this patch will not apply before #5911 is in master, so I guess that's 'waiting'?
dan, diff against master
https://codereview.appspot.com/583750043
Passes make, make check and a full make doc
@hanwen the term 'review' as Jonas says, implies that the patch has been shown to not break against the make, make check and make doc tests for current master (which obviously can be a moveable feast, and is another reason we have this relatively clear patch countdown cycle - as it gives Devs some reasonable chance to not have to perpetually rebase every day because we're pushing to master ad-hoc and their new patches suddenly don't apply)
Some devs prefer to spend their time to check a patch submission once they know it has been 'tested'.
I know this patch cycle has frustrated some devs, but when there are dozens of patches submitted, developers can choose how to plan the limited time they might have and spend it on those patches that are at least shown to have compiled or that are about to be pushed rather than those just submitted and not even tested yet.
As ever, developers can bypass/override this process as they discuss/see fit on the lists
Patch on countdown for April 23rd
This seems to be still under discussion, I am setting this back to review for now.
I think the discussion is more of philosophical one, so I suggest countdown.