Menu

#5895 define-markup-command-internal -> module-define-markup-command!

Started
None
needs_work
Maintainability
2020-04-17
2020-04-12
No

define-markup-command-internal -> module-define-markup-command!

Tangible benefits of this approach are not all that clear, and it
doesn't cover define-markup-list-command in the current form either,
so it warrants more work before committing or even deciding to commit.
Particularly so since for convenience it reverts a previous patch
combining the internals of define-markup-command and
define-markup-list-command, in order to illustrate the approach just
on the former.

However, it works and provides a basis for discussion. The principal
idea is to provide a version of define-markup-command that is not
specific to the current module and not a macro, in a similar vein to
how module-define! complements define , and use this in the parser
rather than the previous somewhat fuzzier
define-markup-command-internal .

Additional commits:

Add Lily_lexer::current_scope () function

Revert "Express define-markup-list-command-internal using define-markup-command-internal"

This reverts commit 9f1683921621b612b94080d506ee317b058b29c8.

http://codereview.appspot.com/547920045

Discussion

  • Anonymous

    Anonymous - 2020-04-12
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-04-12

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-04-15
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-04-15

    Patch on countdown for April 17th

     
  • Anonymous

    Anonymous - 2020-04-17
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-04-17

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2020-04-17
    • Patch: push --> needs_work
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2020-04-17

    Well, basically this was done as an illustration. For a full-blown change, it would also want to cover define-markup-list-command and there has been no feedback from Han-Wen who requested illustrating my proposal. So needs_work for now.

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.