Menu

#5874 Remove all uses of markup macro from scm/*.scm

Fixed
Maintainability
2020-04-10
2020-03-30
No

Remove all uses of markup macro from scm/*.scm

The markup macro is a major portability headache for getting
byte-compilation with Guilev2 to work. This removes all uses of it
from within the scm code base of LilyPond while keeping it around (for
now) for use from files in LilyPond syntax.

This actually also includes the single commit from

Issue 5873: Refactor \markup \pattern

http://codereview.appspot.com/575930043

Discussion

  • Anonymous

    Anonymous - 2020-03-31
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2020-03-31

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-04-02
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-04-02

    Patch on countdown for April 2nd

     
  • Anonymous

    Anonymous - 2020-04-05
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-04-05

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2020-04-05
    • Patch: push --> waiting
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2020-04-05

    Depends on issue 5873 and will get pushed along with it.

     

    Last edit: David Kastrup 2020-04-05
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-10
    • labels: --> Fixed_2_21_1
    • status: Started --> Fixed
    • Patch: waiting -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-10
    commit 39afbb3812d76a26f0ad18c2022b3a5f8b356e66
    Author: David Kastrup <dak@gnu.org>
    Date:   Mon Mar 30 16:03:52 2020 +0200
    
        Issue 5874: Remove all uses of markup macro from scm/*.scm
    
        The markup macro is a major portability headache for getting
        byte-compilation with Guilev2 to work.  This removes all uses of it
        from within the scm code base of LilyPond while keeping it around (for
        now) for use from files in LilyPond syntax.