LilyIssues / Issues / #5853 Cleanup python/ build rules.

Han-Wen Nienhuys - 2020-03-21

larger cleanup

https://codereview.appspot.com/549740043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-21

Description has changed:

Diff:

Needs: -->

Patch: new --> needs_work

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fails make check

Making Documentation/topdocs/out/INSTALL.texi (copy)
Making Documentation/topdocs/out/AUTHORS.texi (copy)
Making Documentation/topdocs/out/README.txt < texi
Making Documentation/topdocs/out/INSTALL.txt < texi
Making Documentation/topdocs/out/AUTHORS.txt < texi
langdefs.py: warning: lilypond-doc gettext domain not found.
Making Documentation/topdocs/out/NEWS.txt < texi
[1]+  Done                    gitk  (wd: ~/lilypond-git)
(wd now: ~/lilypond-git/build)
E
======================================================================
ERROR: test_basic_texi (__main__.TestFindSnippets)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jlowe/lilypond-git/python/book_base_test.py", line 34, in test_basic_texi
    """,  formatter, None)
  File "/home/jlowe/lilypond-git/python/book_base.py", line 262, in find_toplevel_snippets
    snip = klass (type, m, formatter, line_number, global_options)
  File "/home/jlowe/lilypond-git/python/book_snippets.py", line 330, in __init__
    Snippet.__init__ (self, type, match, formatter, line_number, global_options)
  File "/home/jlowe/lilypond-git/python/book_snippets.py", line 297, in __init__
    self.replacements = {'program_version': global_options.information["program_version"],
AttributeError: 'NoneType' object has no attribute 'information'

----------------------------------------------------------------------
Ran 1 test in 0.003s

FAILED (errors=1)
/home/jlowe/lilypond-git/build/.././python/GNUmakefile:29: recipe for target 'local-test' failed
make[2]: *** [local-test] Error 1
/home/jlowe/lilypond-git/build/../GNUmakefile.in:328: recipe for target 'test' failed
make[1]: *** [test] Error 2
/home/jlowe/lilypond-git/build/../GNUmakefile.in:372: recipe for target 'local-check-pre' failed
make: *** [local-check-pre] Error 2

Han-Wen Nienhuys - 2020-03-21

make check passes

https://codereview.appspot.com/549740043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-03-21

summary: Remove @ substitutions from python/*.py --> Cleanup python/ build rules.

Needs: -->

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-21

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-21

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-03-21

rebase on whitespace changes

https://codereview.appspot.com/549740043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-22

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-22

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-23

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-23

Patch on countdown for March 25th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-25

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-25

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-26

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cleanup python/ build rules.
author  Han-Wen Nienhuys <hanwen@lilypond.org>  
    Fri, 20 Mar 2020 22:15:21 +0000 (23:15 +0100)
committer   Han-Wen Nienhuys <hanwen@lilypond.org>  
    Wed, 25 Mar 2020 09:22:51 +0000 (10:22 +0100)
commit  ab7a344f689dd9c523f12e818a6f638e1cb7fd4c

Cleanup python/ build rules.

Issue Tracker for LilyPond

Searches

Help

#5853 Cleanup python/ build rules.

Discussion