Menu

#5845 Fix output-distance tests

Fixed
2020-03-21
2020-03-14
No
  • Call /bin/bash explicitly in system().

  • Hide output in case of success with run-and-check

  • In case of failure, run-and-check tails the log file.

  • Run output-distance as part of default build.

Tested:
Ubuntu Xenial in-tree make, make check.

https://codereview.appspot.com/569540043

Discussion

  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-03-14
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-03-14

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-03-17
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-03-17

    Patch on countdown for March 19th

     
  • Anonymous

    Anonymous - 2020-03-19
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-03-19

    I'm not sure on this - based on discussions in Rietveld - it has had not obvious objections I can see but the '/bin/bash' conversation there isn't clear. Otherwise counted down (push if this is OK with the dev team).

     
  • Anonymous

    Anonymous - 2020-03-21
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2020-03-21
    Fix output-distance tests
    author  Han-Wen Nienhuys <hanwen@lilypond.org>  
        Fri, 13 Mar 2020 23:01:03 +0000 (00:01 +0100)
    committer   Han-Wen Nienhuys <hanwen@lilypond.org>  
        Fri, 20 Mar 2020 11:46:27 +0000 (12:46 +0100)
    commit  fd4021a3725cda2fe41079af8208a629dda39f1a
    
     
MongoDB Logo MongoDB