Menu

#5841 Address output-distance problems:

Fixed
2020-04-16
2020-03-11
No
  • Run output-distance.py from srcdir

  • Fix <meta charset=".."> tag

  • Generate self-test HTML in out/

  • Remove test files afterwards

https://codereview.appspot.com/563730043

Related

Issues: #5841

Discussion

  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-03-12
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
    • Han-Wen Nienhuys

      Jonas said you couldn't run tests anymore. Can you confirm if that is
      the case or not?

      On Thu, Mar 12, 2020 at 8:26 AM pkx166h
      lilypond-pkx@users.sourceforge.net wrote:

      Description has changed:

      Diff:

      Needs: -->
      Patch: new --> review
      Type: -->
      Comment:

      Han-wen this passes make, make test-baseline and a full make doc but as per David's commenst on Rietveld I get the same as he when I do the make test-baseline/apply patch/make check routine.

      I'll put this on review for now.


      [issues:#5841] Address output-distance problems:

      Status: Started
      Created: Wed Mar 11, 2020 11:46 AM UTC by Han-Wen Nienhuys
      Last Updated: Wed Mar 11, 2020 07:59 PM UTC
      Owner: Han-Wen Nienhuys

      Run output-distance.py from srcdir

      Fix <meta charset=".."> tag

      Generate self-test HTML in out/

      Remove test files afterwards

      https://codereview.appspot.com/563730043


      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlilyissues/issues/5841/

      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

       

      Related

      Issues: #5841

  • Anonymous

    Anonymous - 2020-03-12

    Han-wen this passes make, make test-baseline and a full make doc but as per David's commenst on Rietveld I get the same as he when I do the make test-baseline/apply patch/make check routine.

    I'll put this on review for now.

     
  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-03-12
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-03-12

    Patch no longer applies to current master

     
  • Anonymous

    Anonymous - 2020-03-13
    • Patch: review --> needs_work
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-03-14

    there's something in master:

    commit e325a23887fd93e56da2a13dd59a8b82a8ce74a0
    Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
    AuthorDate: Wed Mar 11 20:58:46 2020 +0100
    Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
    CommitDate: Fri Mar 13 15:20:59 2020 +0100
    
        Address output-distance problems:
    
        * Run output-distance.py from srcdir
    
        * Generate self-test HTML in out/
    
        * Remove test files afterwards
    

    This neither enables the test nor fixes the problems on Ubuntu.

     
  • Han-Wen Nienhuys

    it doesn't pretend to.

    It fixes the problems running tidy over .HTML output.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-16
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: needs_work -->
     
MongoDB Logo MongoDB