LilyIssues / Issues / #5836 Added vowel transitions for lyrics

Anonymous - 2020-03-08

Description has changed:

Diff:

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1,3 @@ +Screenshot from 2020-03-08_1.png (40.2 kB; image/png) +Screenshot from 2020-03-08_2.png (24.8 kB; image/png) +Screenshot from 2020-03-08_3.png (62.6 kB; image/png)

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-08

Passes make, make check and a full make doc.

Reg test diffs attached

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Stephen Grant - 2020-03-08

Renamed 'transition line' to 'transition arrow' and documentation fixes.

https://codereview.appspot.com/565750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-08

Passes make, make check and a full make doc.

Reg test diffs attached

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-08

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Stephen Grant - 2020-03-10

Revision following review

https://codereview.appspot.com/565750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-10

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-10

Passes make, make check and a full make doc.

Reg test diffs same as above

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Stephen Grant - 2020-03-11

Removed transition-engraver.cc

https://codereview.appspot.com/565750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-11

Needs: -->

Patch: new --> needs_work

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

This now fails 'make check'

...
creating /home/jlowe/lilypond-git/build/out/test-results/input/regression/out-test/test-output-distance.png
/usr/bin/python3: can't open file 'output-distance.py': [Errno 2] No such file or directory
/home/jlowe/lilypond-git/build/.././scripts/build/GNUmakefile:19: recipe for target 'local-check' failed
make[2]: *** [local-check] Error 2
/home/jlowe/lilypond-git/build/../stepmake/stepmake/generic-targets.make:142: recipe for target 'check' failed
make[1]: *** [check] Error 2
/home/jlowe/lilypond-git/build/../stepmake/stepmake/generic-targets.make:142: recipe for target 'check' failed
make: *** [check] Error 2

Probably to do with some recent commits to master?

Jonas Hahnfeld - 2020-03-12

This looks exactly like the error I saw. Could you please try again with current master?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Stephen Grant - 2020-03-12

Rename to vowel-transition-event

https://codereview.appspot.com/565750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-12

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-12

Passes make, make check and a full make doc.

Reg test diffs same as above

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Stephen Grant - 2020-03-13

Corrected VowelTransitionEvent description

https://codereview.appspot.com/565750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-13

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-13

Passes make, make check and a full make doc.

Reg test diffs same as above

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Stephen Grant - 2020-03-14

Added check to prevent issue if some bounds properties were not available.

https://codereview.appspot.com/565750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-14

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-14

Passes make, make check and a full make doc.

Reg test diffs same as above

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Stephen Grant - 2020-03-15

Replaced property 'minimum-length-includes-padding' with 'minimum-length-correction'.

https://codereview.appspot.com/565750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-15

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-15

Passes make, make check and a full make doc.

New Reg test diffs attached - they looked the same as before but as we'd had a few patches I thought it would be best to upload the latest-and-greatest to be sure

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: