--- old+++ new@@ -1,5 +1,6 @@Don't add . to PATH in Make
-That's a really big security no-no.+ That was apparently done by accident and may draw unexpected+ executable files into the action.http://codereview.appspot.com/563650043
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-03-05
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-03-05
Patch on countdown for March 7th
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I am fast-tracking this one. Reasons: it is obviously™ right. And another issue of mine ready to get into review critically depends on it. Which is how I discovered it.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
Passes make, make check and a full make doc.
Diff:
Patch on countdown for March 7th
I am fast-tracking this one. Reasons: it is obviously™ right. And another issue of mine ready to get into review critically depends on it. Which is how I discovered it.
Pushed to staging as
commit 825dd87d0b1b58e56d7c66ef1fc1dd672d913c84
Author: David Kastrup dak@gnu.org
Date: Wed Mar 4 03:10:37 2020 +0100