LilyIssues / Issues / #5814 stepmake: use patsubst for finding build-dir

Issue Tracker for LilyPond

#5814 stepmake: use patsubst for finding build-dir

Status: Fixed

Owner: Han-Wen Nienhuys

Labels: Fixed 2_21_0 (1)

Needs:

Patch:

Type:

Updated: 2020-03-07

Created: 2020-03-01

Creator: Han-Wen Nienhuys

Private: No

The previous approach used $(subst ) which replaces all occurrences.
This lead to surprising results when the top-build-dir was called
/lilypond, as it is in the Docker builds.

https://codereview.appspot.com/575750043

Discussion

Anonymous - 2020-03-01

Description has changed:

Diff:

Needs: -->

Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

I cannot get this patch to run past the 'configure' after applying it (after I have done the make/make test-baseline'. I get a stepmake error.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-03-03

separate builddir

https://codereview.appspot.com/575750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-03

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-03

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-05

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-05

Patch on countdown for March 7th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-07

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-07

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-07

labels: --> Fixed 2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

stepmake: use patsubst for finding build-dir master staging
author  Han-Wen Nienhuys <hanwen@lilypond.org>  
    Sun, 1 Mar 2020 13:03:36 +0000 (14:03 +0100)
committer   Han-Wen Nienhuys <hanwen@lilypond.org>  
    Sat, 7 Mar 2020 10:33:05 +0000 (11:33 +0100)
commit  febe487bb45c97f97377536a5d15da80cce80297

stepmake: use patsubst for finding build-dir

Issue Tracker for LilyPond

Searches

Help

#5814 stepmake: use patsubst for finding build-dir

Discussion