LilyIssues / Issues / #5805 sources: fix handling of non-existent include files

Issue Tracker for LilyPond

#5805 sources: fix handling of non-existent include files

Status: Fixed

Owner: Han-Wen Nienhuys

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type:

Updated: 2020-03-04

Created: 2020-02-28

Creator: Han-Wen Nienhuys

Private: No

A recent refactoring calles String::String on a null pointer for
non-existent files.

https://codereview.appspot.com/547700043

Discussion

Jonas Hahnfeld - 2020-02-28

Could you please be explicit which commit "broke" this? This will make it easier to link the two in the future.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-02-28

link commit

https://codereview.appspot.com/547700043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-28

Description has changed:

Diff:

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-28

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

Patch on countdown for March 3rd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-03

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-03

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-04

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

sources: fix handling of non-existent include files master staging
author  Han-Wen Nienhuys <hanwen@lilypond.org>  
    Fri, 28 Feb 2020 18:03:23 +0000 (19:03 +0100)
committer   Han-Wen Nienhuys <hanwen@lilypond.org>  
    Tue, 3 Mar 2020 19:35:47 +0000 (20:35 +0100)
commit  1bba00b04f1379972c9dd24717067aa10643229c

sources: fix handling of non-existent include files

Issue Tracker for LilyPond

Searches

Help

#5805 sources: fix handling of non-existent include files

Discussion