LilyIssues / Issues / #5804 Do not allow page breaks on the first column of a score

#5804 Do not allow page breaks on the first column of a score

Status: Fixed

Owner: Han-Wen Nienhuys

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2020-03-10

Created: 2020-02-28

Creator: Han-Wen Nienhuys

Private: No

This duplicates a column index in the vector of allowed break points,
causing a crash.

Do some more sanity checking on the input of Constrained_breaking.

Fixes #5801

https://codereview.appspot.com/581720054

Discussion

Anonymous - 2020-02-28

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-28

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

Patch on countdown for March 3rd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-03

This looks like it needs work from the comment on Rietveld - however as it passed the 'normal tests' I will leave this on countdown for March 5th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-05

Patch: countdown --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-05

I am going to put this back to review based on Rietveld comments

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-07

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-07

Patch on countdown for March 9th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-09

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-09

Patch counted down, please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-03-10

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit ad039e1de14135b9d3bc1bb6d71f729abdc53311
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Fri Feb 28 17:02:38 2020 +0100
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Mon Mar 9 09:45:03 2020 +0100

    Do not allow page breaks on the first column of a score

    This duplicates a column index in the vector of allowed break points,
    causing a crash.

    Do some more sanity checking on the input of Constrained_breaking.

Do not allow page breaks on the first column of a score

Issue Tracker for LilyPond

Searches

Help

#5804 Do not allow page breaks on the first column of a score

Discussion