Menu

#5803 output-distance: treat non-existent files as empty string

Started
5824 (1)
abandoned
2020-03-07
2020-02-28
No

This avoids callings strip() on None

https://codereview.appspot.com/583590043

Discussion

  • Anonymous

    Anonymous - 2020-02-28
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-28

    Passes make, make check and a full make doc.

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-02-29
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-02-29

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-03-03
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-03-03

    Patch on countdown for March 5th - please address the concerns on Rietveld though.

     
  • Anonymous

    Anonymous - 2020-03-05

    Leaving on Countdown based on comments on Rietveld

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-03-05
    • Needs: -->
    • Patch: new --> push
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-03-05

    Passes make, make check and a full make doc. if this is just a reword of a comment, I don't see why this cannot be pushed. Sorry, I didn't get that the request was so trivial initailly.

     
  • Han-Wen Nienhuys

    • labels: --> 5824
    • Patch: push --> abandoned
     
  • Han-Wen Nienhuys

    superseeded by 5824