Menu

#5796 aclocal.m4 (STEPMAKE_GUILE_DEVEL): Fix logic and improve diagnostics.

Fixed
Enhancement
2020-03-03
2020-02-25
No

Add quotes around string argument that contains a logical operator to avoid
unexpected results.

Also use $PKG_CONFIG everywhere.

https://codereview.appspot.com/573570044

Discussion

  • Werner LEMBERG

    Werner LEMBERG - 2020-02-28
    • Description has changed:

    Diff:

    
    
    • assigned_to: Werner LEMBERG
    • Needs: -->
     
  • Anonymous

    Anonymous - 2020-02-28
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-28

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-03-01
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-03-01

    Patch on countdown for March 3rd

     
  • Anonymous

    Anonymous - 2020-03-03
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-03-03

    Patch counted down - please push.

     
  • Werner LEMBERG

    Werner LEMBERG - 2020-03-03
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Werner LEMBERG

    Werner LEMBERG - 2020-03-03

    Pushed to staging as

    commit 0b5b0437785665361488508e71bba1da714f49d6
    Author: Werner Lemberg wl@gnu.org
    Date: Tue Feb 25 12:53:49 2020 +0100

    Issue 5796: aclocal.m4 (STEPMAKE_GUILE_DEVEL): Fix logic and improve diagnostics
    
    Add quotes around string argument that contains a logical operator to avoid
    unexpected results.
    
    Also use $PKG_CONFIG everywhere.