Menu

#5792 .dir-locals.el: spell out nil settings

Fixed
Enhancement
2020-02-28
2020-02-25
No

.dir-locals.el: spell out nil settings

.dir-locals.el establishes our formatting conventions when writing and
formatting stuff with Emacs. Since it has been written from within
Emacs using M-x add-dir-local-variable RET it spelled
(indent-tabs-mode . nil) as (indent-tabs-mode) which is confusing to
human readers. So the file has been changed in the repo to the more
explicit form. While this will not survive further applications of
M-x add-dir-local-variable RET, users are then responsible for their
own differences.

http://codereview.appspot.com/545640044

Discussion

  • Anonymous

    Anonymous - 2020-02-25
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-25

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-26
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-26

    Patch on countdown for Feb 28th

     
  • Anonymous

    Anonymous - 2020-02-28
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-28

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2020-02-28
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2020-02-28
    Issue 5792: .dir-locals.el: spell out nil settings master staging
    author  David Kastrup <dak@gnu.org> 
        Tue, 25 Feb 2020 11:08:28 +0000 (12:08 +0100)
    committer   David Kastrup <dak@gnu.org> 
        Fri, 28 Feb 2020 17:00:31 +0000 (18:00 +0100)
    commit  4c61b90178892bd136d02fe3cb7c5c91fc76c07c