LilyIssues / Issues / #5787 Add a cooperative FS lock to lilypond-book.

Issue Tracker for LilyPond

#5787 Add a cooperative FS lock to lilypond-book.

Status: Fixed

Owner: Han-Wen Nienhuys

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type:

Updated: 2020-03-05

Created: 2020-02-23

Creator: Han-Wen Nienhuys

Private: No

This simplifies the build infrastructure, because it obviates Makefile
hacks to force a single lilypond-book processes during the build

https://codereview.appspot.com/555360043

Discussion

Han-Wen Nienhuys - 2020-02-23

fcntl

https://codereview.appspot.com/555360043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-02-23

timing test

https://codereview.appspot.com/555360043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-02-23

spaces

https://codereview.appspot.com/555360043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-02-23

eager checksums

https://codereview.appspot.com/555360043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-02-23

harden

https://codereview.appspot.com/555360043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-24

Passes make. make check and a full make doc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-02-26

lockfilename

https://codereview.appspot.com/555360043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-26

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-26

Passes make. make check and a full make doc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-28

This looks like it is still under discussion, so I am leaving this on review for now.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

Sorry, mistake. Patch on countdown for March 3rd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-03-01

rebase

https://codereview.appspot.com/555360043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-01

Passes make. make check and a full make doc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-03

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-03

Patch on countdown for March 5th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-05

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-03-05

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-03-05

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit 7ab9c8fa4faff7a513d0ecfbc7eecf7efd2b8ea8
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Sun Mar 1 17:47:53 2020 +0100
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Thu Mar 5 12:18:23 2020 +0100

    Add a FS lock to lilypond-book

    This simplifies the build infrastructure, because it obviates Makefile
    hacks to force a single lilypond-book processes during the build

    This uses a fcntl-based lock, which is managed by the kernel. This
    means there is no chance of the locks going stale (except on NFS)

    Remove limitations on parallelism in build system.

Add a cooperative FS lock to lilypond-book.

Issue Tracker for LilyPond

Searches

Help

#5787 Add a cooperative FS lock to lilypond-book.

Discussion