Menu

#5778 Implement Grob::event_cause, Grob::ultimate_event_cause

Fixed
2020-02-25
2020-02-20
No

Implement Grob::event_cause, Grob::ultimate_event_cause

Those were implemented in Grob_info only previously which does not make a lot of sense,
given that they don't access anything particular to Grob_info.

Also contains commit:

Use Grob::event_cause and Grob::ultimate_event_cause where useful

Frankly, this one has been bugging me on and off for years. I just
had one compilation error too much today.

http://codereview.appspot.com/559500043

Discussion

  • Anonymous

    Anonymous - 2020-02-20
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-20

    Passes make. make check and a full make doc

     
  • Anonymous

    Anonymous - 2020-02-21
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-02-22
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-22

    Patch on countdown for Feb 24th

     
  • Anonymous

    Anonymous - 2020-02-24
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-24

    Patch counted down - please push.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-25
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-25
    commit 7495e987bce4ced7926b641c9119d1e9efce0683
    Author:     David Kastrup <dak@gnu.org>
    AuthorDate: Thu Feb 20 16:08:17 2020 +0100
    Commit:     David Kastrup <dak@gnu.org>
    CommitDate: Mon Feb 24 21:35:32 2020 +0100
    
        Issue 5778/2: Use Grob::event_cause and Grob::ultimate_event_cause where useful
    
    commit bd102efc3768c735b10a79397e11df55c8957818
    Author:     David Kastrup <dak@gnu.org>
    AuthorDate: Thu Feb 20 15:50:29 2020 +0100
    Commit:     David Kastrup <dak@gnu.org>
    CommitDate: Mon Feb 24 21:35:32 2020 +0100
    
        Issue 5778/1: Implement Grob::event_cause, Grob::ultimate_event_cause
    
        Those were implemented in Grob_info only previously which does not make a lot of sense,
        given that they don't access anything particular to Grob_info.