Menu

#5757 Add a RAII wrapper for extracting FT_Face from PangoFcFont

Fixed
Enhancement
2020-02-21
2020-02-13
No

This reduces the number of deprecation warnings for
pango_fc_font_[un]lock_face().

https://codereview.appspot.com/549560043

Discussion

  • Anonymous

    Anonymous - 2020-02-13
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-13

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-16
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-16

    Patch on countdown for Feb 18th

     
  • Anonymous

    Anonymous - 2020-02-18
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-18

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2020-02-18
    • Patch: push --> waiting
     
  • David Kastrup

    David Kastrup - 2020-02-18

    Backed out of staging together with non-working patch for issue 5756 since I don't know whether this issue relies on the minimum version established by issue 5756. Feel free to change status as appropriate.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-21
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: waiting -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-21
    commit 9cf8d35e8c0ebf0f2b56ec74d3b0187b2cd493b8
    Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
    AuthorDate: Thu Feb 13 14:26:55 2020 +0100
    Commit:     David Kastrup <dak@gnu.org>
    CommitDate: Thu Feb 20 12:58:57 2020 +0100
    
        Add a RAII wrapper for extracting FT_Face from PangoFcFont
    
        This reduces the number of deprecation warnings for
        pango_fc_font_[un]lock_face().
    
        https://sourceforge.net/p/testlilyissues/issues/5757
        http://codereview.appspot.com/549560043