#5756 Make Pango >= 1.36 mandatory.

[Han-Wen Nienhuys]

Pango 1.36 was released in 2013.

https://codereview.appspot.com/565660044

[Han-Wen Nienhuys]

pango_enable_backend

https://codereview.appspot.com/565660044

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for Feb 18th

[Anonymous]

Patch counted down - please push.

[David Kastrup]

Patch broke build, backed out of staging.

Error log excerpt:
10:35:17 (UTC) Begin LilyPond compile, previous commit at b16c3d14f3d1f10aa919e70107e6103c67a9aa01
10:35:20 Merged staging, now at: b16c3d14f3d1f10aa919e70107e6103c67a9aa01
10:35:21 Success: ./autogen.sh --noconfigure
10:35:34 Success: /tmp/lilypond-autobuild/configure --enable-checking
10:35:37 Success: nice make clean
10:37:17 *** FAILED BUILD ***
nice make -j9 CPU_COUNT=9
Previous good commit: ce072002412d48f48cc4ff4620d82f700e816225
Current broken commit: b16c3d14f3d1f10aa919e70107e6103c67a9aa01
10:37:17 *** FAILED STEP ***
merge from staging
Failed runner: nice make -j9 CPU_COUNT=9
See the log file log-staging-nice-make--j9-CPU_COUNT=9.txt
10:37:17 Traceback (most recent call last):
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/init.py", line 528, in handle_staging
self.build (issue_id=issue_id)
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/init.py", line 316, in build
issue_id)
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/init.py", line 266, in runner
raise FailedCommand ("Failed runner: %s\nSee the log file %s" % (command, this_logfilename))
FailedCommand: Failed runner: nice make -j9 CPU_COUNT=9
See the log file log-staging-nice-make--j9-CPU_COUNT=9.txt

Making lily/out/keyword.o < cc
Making lily/out/simple-spacer-scheme.o < cc
Making lily/out/episema-engraver.o < cc
Making lily/out/lyric-extender.o < cc
Making lily/out/includable-lexer.o < cc
Making lily/out/timing-translator.o < cc
Making lily/out/pango-font.o < cc
Making lily/out/part-combine-part-iterator.o < cc
Making lily/out/horizontal-bracket.o < cc
/tmp/lilypond-autobuild/lily/pango-font.cc: In member function
'Stencil Pango_font::pango_item_string_stencil(const PangoGlyphItem)
const':
/tmp/lilypond-autobuild/lily/pango-font.cc:229:28: error: invalid use
of incomplete type 'PangoFcFont' {aka 'struct _PangoFcFont'}
229 | FcPattern fcpat = fcfont->font_pattern;
| ^~
In file included from /usr/include/pango-1.0/pango/pangoft2.h:29,
from /tmp/lilypond-autobuild/lily/pango-font.cc:20:
/usr/include/pango-1.0/pango/pangofc-font.h:47:16: note: forward declaration of 'PangoFcFont' {aka 'struct _PangoFcFont'}
47 | typedef struct _PangoFcFont PangoFcFont;
| ^~~~~~~~~~~~
Making lily/out/clef-engraver.o < cc
Making lily/out/key-performer.o < cc
make[1]: ***
[/tmp/lilypond-autobuild/stepmake/stepmake/c++-rules.make:5:
out/pango-font.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: ***
[/tmp/lilypond-autobuild/stepmake/stepmake/generic-targets.make:6:
all] Error 2

[Jonas Hahnfeld]

Fixed commit in master:

commit 15b711841071f78b436bdd271d98145b180efe86
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Thu Feb 13 13:54:20 2020 +0100
Commit:     David Kastrup <dak@gnu.org>
CommitDate: Thu Feb 20 12:58:57 2020 +0100

    Make Pango >= 1.36 mandatory.

    Pango 1.36 was released in 2013.

    https://sourceforge.net/p/testlilyissues/issues/5756
    http://codereview.appspot.com/565660044