Menu

#5744 parser-ly-from-scheme: Make #{ compilable

Fixed
Enhancement
2020-02-13
2020-02-08
No

parser-ly-from-scheme: Make #{ compilable

For better or worse, Guile 2 has problems byte-compiling function
values. Factor out the previous internal function
read-lily-expression-internal and refer to it by (module-relative)
name rather than value in Guile 2.

http://codereview.appspot.com/581610043

Discussion

  • Anonymous

    Anonymous - 2020-02-08
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-08

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-10

    Patch on countdown for Feb 12th

     
  • Anonymous

    Anonymous - 2020-02-12
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-12

    Patch counted down - please push (I think Thomas' commenst on Rietveld are not stopping this but I could be wrong, please check).

     
    • Thomas Morley

      Thomas Morley - 2020-02-12

      Fine with me, my comments are off-topic anyway.

       
      • David Kastrup

        David Kastrup - 2020-02-12

        Sorry, I wanted to write that I checked, and I just forgot.

         
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-13
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-13
    commit 392548cec54f71cfcc07d104c60dfb317b0638fc
    Author:     David Kastrup <dak@gnu.org>
    AuthorDate: Sat Feb 8 18:23:54 2020 +0100
    Commit:     David Kastrup <dak@gnu.org>
    CommitDate: Wed Feb 12 13:19:01 2020 +0100
    
        Issue 5744: parser-ly-from-scheme: Make #{ compilable
    
        For better or worse, Guile 2 has problems byte-compiling function
        values.  Factor out the previous internal function
        read-lily-expression-internal and refer to it by (module-relative)
        name rather than value in Guile 2.
    
     
MongoDB Logo MongoDB