Menu

#5735 Rewrite define-session and define-session-public macros

Fixed
Patch
2020-02-06
2020-02-04
No

Rewrite define-session and define-session-public macros

The byte compiler of Guile-2.x is not able to compile anonymous
functions/closures into constants. Rewriting the macros not to rely
on such constants by moving the local functions into their own
function definitions is the easiest expedient.

http://codereview.appspot.com/549510043

Discussion

  • Anonymous

    Anonymous - 2020-02-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-05

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-06

    Patch on countdown for Feb 8th.

     
  • David Kastrup

    David Kastrup - 2020-02-06

    As this is a sort-of trivial rewrite with no user-accessible consequences and needed for Han-Wen's work on Guile 2, I am pushing this early. I'd have done it sooner but had too much on the plate. Sorry for that.

     
    👍
    1
  • David Kastrup

    David Kastrup - 2020-02-06
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: countdown -->
    • Type: Enhancement --> Patch
     
  • David Kastrup

    David Kastrup - 2020-02-06

    Pushed to staging as
    commit c066a53f9e3a4809283ba2934a2e8f1e6c44211b
    Author: David Kastrup dak@gnu.org
    Date: Tue Feb 4 22:02:20 2020 +0100

    Issue 5735: Rewrite define-session and define-session-public macros
    
    The byte compiler of Guile-2.x is not able to compile anonymous
    functions/closures into constants.  Rewriting the macros not to rely
    on such constants by moving the local functions into their own
    function definitions is the easiest expedient.
    
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.