Menu

#5733 Fix various type-conversion warnings

Fixed
Dan Eble
Enhancement
2020-02-08
2020-02-03
Dan Eble
No

1: int->size_t in make_script_from_event ()
... and similarly in Fingering_engraver::make_script ().
This fixes some warnings.

2: Fix scm_from_... () with wrong types

3: Fix type-conversion warning in Scale
Assert that scale size is less than the max int value.

4: int->vsize in Dot_column

https://codereview.appspot.com/559450053

Discussion

  • Anonymous

    Anonymous - 2020-02-04
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-04

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-06

    Patch on countdown for Feb 8th.

     
  • Anonymous

    Anonymous - 2020-02-08
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-08

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2020-02-08
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Dan Eble

    Dan Eble - 2020-02-08
    commit 7362fcde459d888f40523624db9e60cf9a369d48
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Mon Feb 3 15:08:08 2020 -0500
    
        Issue 5733/4: int->vsize in Dot_column
    
        fixes warning
    
    commit e302af56687111bcc2a8db883b2478d8fc642ced
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Sun Feb 2 15:57:12 2020 -0500
    
        Issue 5733/3: Fix type-conversion warning in Scale
    
        Assert that scale size is less than the max int value.
    
    commit 4951c5b23a1ec650476f6a42d3cf335457619094
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Sat Feb 8 07:01:39 2020 -0500
    
        Issue 5733/2: Fix scm_from_... () with wrong types
    
    commit 4e9671270e20dac786ab08400218dfc7a5508424
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Sun Feb 2 14:45:08 2020 -0500
    
        Issue 5733/1: int->size_t in make_script_from_event ()
    
        ... and similarly in Fingering_engraver::make_script ().
        This fixes some warnings.