Menu

#5728 GUILE v2: set postscript output port to Latin1

Fixed
Enhancement
2020-02-08
2020-02-02
No

OTF fonts are embedded as binary data, so the output port encoding is
important here.

https://codereview.appspot.com/563400065

Discussion

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-02
    • summary: rebase --> GUILE v2: set postscript output port to Latin1
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,4 @@
    +OTF fonts are embedded as binary data, so the output port encoding is
    +important here.
    +
     https://codereview.appspot.com/563400065
    
    • Needs: -->
     
  • Anonymous

    Anonymous - 2020-02-02
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-02

    Passes make, make check a d a full make doc,

     
  • Anonymous

    Anonymous - 2020-02-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-04

    Patch on countdown for Feb 6th.

     
  • Anonymous

    Anonymous - 2020-02-06
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-06

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2020-02-08
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2020-02-08
    GUILE v2: set postscript output port to Latin1
    author  Han-Wen Nienhuys <hanwen@lilypond.org>  
        Sun, 26 Jan 2020 08:57:52 +0000 (09:57 +0100)
    committer   Han-Wen Nienhuys <hanwen@lilypond.org>  
        Fri, 7 Feb 2020 11:32:23 +0000 (12:32 +0100)
    commit  7d7bba8fb21babe971d5cf4b2f259219889ae7f7
    
     
  • David Kastrup

    David Kastrup - 2020-02-08

    This appears to have the same goal as the just committed
    commit 1ff6f65960aaa8433530432b46af2daef391746c
    Author: Antonio Ospite ao2@ao2.it
    Date: Sat Nov 19 15:25:56 2016 +0100

    GUILE2: Fix the encoding of the postscript output
    
    Postscript files have to be encoded in Latin1, otherwise ghostscript
    fails to handle them.
    

    has. Please compare them, and if one of them appears preferable to the other, consider reverting the other.