Menu

#5724 Some cleanups for Python code

Fixed
Enhancement
2020-02-06
2020-02-02
No

Some cleanups for Python code

Individual changes:
1) Update documentation for Python 3

2) Use gettext.install() for translations

This conveniently installs _() into Python's builtins namespace.

3) Drop require_python_version()

The implemented 'help' for the user by opening the browser does
not work on Linux anyway.

4) Suggested changes for a newer version of Python

Some comments already referred to simpler code, let's do it.

http://codereview.appspot.com/551430044

Discussion

  • Anonymous

    Anonymous - 2020-02-02
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-02

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-04

    Patch on countdown for Feb 6th.

     
  • Anonymous

    Anonymous - 2020-02-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-06
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-06

    Patch counted down - please push.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-06
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-06

    pushed to staging

    commit bb52caf630fcbebb8390b02fb8bbe54dbaa1be9b
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Sat Feb 1 15:56:48 2020 +0100
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Thu Feb 6 12:02:32 2020 +0100
    
        Issue 5724/4: Suggested changes for a newer version of Python
    
        Some comments already referred to simpler code, let's do it.
    
    commit 3baffb595e43751f11a1055dc6869a77c6bc9bee
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Sat Feb 1 15:55:27 2020 +0100
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Thu Feb 6 12:02:28 2020 +0100
    
        Issue 5724/3: Drop require_python_version()
    
        The implemented 'help' for the user by opening the browser does
        not work on Linux anyway.
    
    commit 81647c9df7b2e972b8d0a00bb5f63742000511a7
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Sat Feb 1 15:53:27 2020 +0100
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Thu Feb 6 12:02:24 2020 +0100
    
        Issue 5724/2: Use gettext.install() for translations
    
        This conveniently installs _() into Python's builtins namespace.
    
    commit ede0457988716a5e6fa0dd1757db0ebd96107bbc
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Sat Feb 1 15:46:26 2020 +0100
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Thu Feb 6 12:02:15 2020 +0100
    
        Issue 5724/1: Update documentation for Python 3