Menu

#5723 Pedal_type_info maintenance

Fixed
Dan Eble
Enhancement
2020-02-06
2020-02-01
Dan Eble
No

1: use C++11 member default values
2: use std::string instead of dubious strdup

https://codereview.appspot.com/557270049

Discussion

  • Anonymous

    Anonymous - 2020-02-01
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-01

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-04

    Patch on countdown for Feb 6th.

     
  • Anonymous

    Anonymous - 2020-02-06
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-06

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2020-02-06
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Dan Eble

    Dan Eble - 2020-02-06
    commit 1ca89d95f9385c7c7cea2c52ecf1df63ef45be3e
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Sat Feb 1 12:39:18 2020 -0500
    
        Issue 5723/2: Pedal_type_info: use std::string instead of dubious strdup
    
    commit 40974cdd62519b27f0ab21a45c678d61c7e72dc1
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Sat Feb 1 12:38:34 2020 -0500
    
        Issue 5723/1: Pedal_type_info: use C++11 member default values