Menu

#5722 lilypond-book: Remove custom package loading

Fixed
Enhancement
2020-02-06
2020-02-01
No

lilypond-book: Remove custom package loading

AFAICT this feature is not documented and only used for the musicxml
testsuite. However the output of the formatter in the loaded module
book-musicxml-testsuite.py only differs by whitespace from the default.
(This also gets rid of the deprecation warning for module 'imp'.)

http://codereview.appspot.com/553490051

Discussion

  • Anonymous

    Anonymous - 2020-02-01
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-02-01

    Passes make. make test-baseline and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-04

    Patch on countdown for Feb 6th.

     
  • Anonymous

    Anonymous - 2020-02-06
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-06

    Patch counted down - please push.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-06
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-06

    pushed to staging

    commit 80bc78474ca27f2e3bef1b30abe68b777577fec2
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Fri Jan 31 09:37:11 2020 +0100
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Thu Feb 6 12:01:19 2020 +0100
    
        Issue 5722: lilypond-book: Remove custom package loading
    
        AFAICT this feature is not documented and only used for the musicxml
        testsuite. However the output of the formatter in the loaded module
        book-musicxml-testsuite.py only differs by whitespace from the default.
        (This also gets rid of the deprecation warning for module 'imp'.)