Menu

#5719 Tie formatting maintenance

Fixed
Dan Eble
Enhancement
2020-02-04
2020-01-31
Dan Eble
No

1: int->vsize to fix tie-formatting warnings

2: Replace flower's Tuple with std::array

3: ties->front () instead of ties->at (0)
... in contexts where ties->back () is also used.

4: Tie_formatting_problem: [i] instead of at (i)
... in loops where it is clear that the index is in bounds.

at () checks the index, which is unnecessary in those places.

https://codereview.appspot.com/581560049

Discussion

  • Anonymous

    Anonymous - 2020-01-31
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-01-31

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2020-02-02
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-02

    Patch on countdown for Feb 4th

     
  • Anonymous

    Anonymous - 2020-02-04
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-04

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2020-02-04
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Dan Eble

    Dan Eble - 2020-02-04
    commit 937e413c0f399b2ec44785b7ca29d61cf7b24cff
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Fri Jan 31 13:48:35 2020 -0500
    
        Issue 5719/4: Tie_formatting_problem: [i] instead of at (i)
    
        ... in loops where it is clear that the index is in bounds.
        at () checks the index, which is unnecessary in these places.
    
    commit 6321ffc39a276d0de4b13bfa105fbc7940278959
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Fri Jan 31 11:54:18 2020 -0500
    
        Issue 5719/3: ties->front () instead of ties->at (0)
    
        ... in contexts where ties->back () is also used.
        at () checks the index, which is unnecessary in these places.
    
    commit f7fdee569ca0929d58bce6d75960f419e941d393
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Fri Jan 31 10:47:49 2020 -0500
    
        Issue 5719/2: Replace flower's Tuple with std::array
    
    commit c4879542d28410081c7dcc6ab198897594054ffb
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Fri Jan 31 10:13:07 2020 -0500
    
        Issue 5719/1: int->vsize to fix tie-formatting warnings