Menu

#5718 Grow heap aggressively during music interpretation

Fixed
2020-02-13
2020-01-31
No

During the interpretation stage, we build up a large set of
Grobs. Without tuning, GC is ineffective, because the Grobs are live
data and can't be collected.

To remedy this, if we see an unsuccessful GC step in the
Score_engraver we increase the heap size explicitly

Total GC overhead for mozart-hrn-3:
without initial heap size: 1.7s
with initial heap size set: ~1.2s
with heap scaling: ~0.25s

https://codereview.appspot.com/561390043

Related

Issues: #5718

Discussion

1 2 > >> (Page 1 of 2)
  • Anonymous

    Anonymous - 2020-01-31
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-01-31

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-01
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-02-01

    Passes make, make check and a full make doc.

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-02-01
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-02-01

    Passes make, make check and a full make doc.

     
  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-02-02
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-02-02

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-02-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-02-04

    Patch on countdown for Feb 6th.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-05
    • Patch: countdown --> review
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-05

    Setting back to review, fails for large scores.

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-02-08
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-02-08

    Passes make, make test-baseline and a full make doc.

     
  • Han-Wen Nienhuys

    Use smob count as memory proxy

    https://codereview.appspot.com/561390043

     
  • Anonymous

    Anonymous - 2020-02-08
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-02-08

    Passes make, make check and a full make doc.

     
  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
1 2 > >> (Page 1 of 2)