Menu ▾ ▴

#5713 Remove likely dead code from set_property_from_event

Fixed
Dan Eble
Fixed_2_21_0 (565)
Enhancement
2020-02-04
2020-01-31
Dan Eble
No

I couldn't find input that would reach this block. With this block out
of the way, type_check_assignment () will vet all values. Its current
behavior is to assert () that the value is defined.

https://codereview.appspot.com/557260047

Discussion

  • Anonymous

    Anonymous - 2020-01-31
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2020-01-31

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2020-02-02
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2020-02-02

    Patch on countdown for Feb 4th

     

  • Anonymous

    Anonymous - 2020-02-04
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2020-02-04

    Patch counted down - please push.

     

  • Dan Eble

    Dan Eble - 2020-02-04
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2020-02-04 
    commit d6956e8ed6da831574cd9bcadb05ac0c47c84a07
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Thu Jan 30 17:38:20 2020 -0500